Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved color passing and configuration #50

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Improved color passing and configuration #50

merged 4 commits into from
Oct 19, 2023

Conversation

hbmartin
Copy link
Contributor

@hbmartin hbmartin commented Oct 19, 2023 •
edited
Loading

  • Allows disabling error color on phone number input
  • Passed background color into country picker dialog
  • NOTE: will have to upgrade AS to Hedgehog RC once this is merged

@hbmartin hbmartin requested a review from omarsanchezv October 19, 2023 14:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

omarsanchezv
omarsanchezv approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@omarsanchezv omarsanchezv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbmartin hbmartin merged commit 4942544 into master Oct 19, 2023
@hbmartin hbmartin temporarily deployed to github-pages October 19, 2023 22:57 — with GitHub Actions Inactive
@hbmartin hbmartin deleted the hm/improved-colors branch November 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarsanchezv omarsanchezv omarsanchezv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbmartin @omarsanchezv